Further Prune PostProcessing Code, Specifically plot_posterior And spread_draws #431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #431 +/- ##
==========================================
+ Coverage 94.51% 96.63% +2.12%
==========================================
Files 42 41 -1
Lines 1003 952 -51
==========================================
- Hits 948 920 -28
+ Misses 55 32 -23
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…tprocessing-code-specifically-plot_posterior-and-spread_draws
…nt of plot_plosterior
pyproject.toml: DEP002 'matplotlib' defined as a dependency but not used in the codebase@AFg6K7h4fhy2 can you remove? |
|
@dylanhmorris it is used in the tutorials, which I don't think deptry recognizes |
|
Remove from the main dependency group and add to |
…ically-plot_posterior-and-spread_draws
damonbayer
reviewed
Oct 2, 2024
damonbayer
reviewed
Oct 2, 2024
damonbayer
reviewed
Oct 2, 2024
damonbayer
reviewed
Oct 2, 2024
damonbayer
reviewed
Oct 2, 2024
…_posterior-and-spread_draws' of github.com:CDCgov/multisignal-epi-inference into 426-further-prune-postprocessing-code-specifically-plot_posterior-and-spread_draws
damonbayer
reviewed
Oct 3, 2024
| ax.plot( | ||
| np.arange(dow_effect_raw.shape[0]), | ||
| dow_plot_samples.mean(dim="draw"), | ||
| color="red", |
There was a problem hiding this comment.
this plot still has the old colors
damonbayer
requested changes
Oct 3, 2024
There was a problem hiding this comment.
one more plot to fix, then it will be ready to merge! Thanks @AFg6K7h4fhy2
damonbayer
approved these changes
Oct 3, 2024
damonbayer
deleted the
426-further-prune-postprocessing-code-specifically-plot_posterior-and-spread_draws
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR: